Update get_serializer_class to consider the request method
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamella
commented
May 23, 2024
There was a problem hiding this comment.
GenericAPIViewGetSerializerClassTests tests the changes made in this file.
pamella
commented
May 23, 2024
| ListModelMixin, | ||
| RetrieveModelMixin, | ||
| UpdateModelMixin, | ||
| ) | ||
|
|
||
|
|
||
| class GenericAPIView(generics.GenericAPIView): |
There was a problem hiding this comment.
fjsj
reviewed
May 27, 2024
drf_rw_serializers/generics.py
Outdated
| (Eg. admins get full serialization, others get basic serialization) | ||
| """ | ||
| if hasattr(self, "request"): | ||
| if self.request.method in ["GET"]: |
There was a problem hiding this comment.
Do you know if HEAD, OPTIONS or TRACE would get the write serializer? I imagine they should get the read one, but they don't have a body, so I'm not sure if it would really do anything.
There was a problem hiding this comment.
Yes, currently they would get the write serializer. Should I include those values in the condition?
There was a problem hiding this comment.
Related change: commit 58e95c3. Let me know if there are any adjustments to make to it.
fjsj
reviewed
May 27, 2024
fjsj
approved these changes
May 27, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe in a couple of sentence what this PR adds
get_serializer_classto consider the request method. See the updated docstring.self.read_serializer_class.self.write_serializer_class.self.serializer_class.Note
Once this PR is approved and merged, I will open another one updating the package version so we can publish it to PyPI.
Dependencies: dependencies on other outstanding PRs, issues, etc.
Resolves #1
Resolves #17
Resolves #44
Merge deadline: List merge deadline (if any)
N/A
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
serializer_class,read_serializer_class, andwrite_serializer_class.Screencast.from.23-05-2024.16.55.32.webm
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.